Improve temp dir generation + cleanup #449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <wagoodman@gmail.com>
Signed-off-by: Alex Goodman <wagoodman@gmail.com>
|
Given the comments on anchore/stereoscope#71 this will need to be brought in under #448 to account for cleanup interface changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in the changes from anchore/stereoscope#71 as well as imports the
file.TempDirGeneratorto follow the same pattern used in stereoscope. In the near future we can split out some of thefilepackage functionality in stereoscope into another repo.Note: tests will fail until the stereoscope PR is merged and the go.mod is updated here. Also note that the base branch is
split-ui-and-event-handlingwhich should be merged first and the base here changed tomain.Partially addresses #416